Github user liufengdb commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20385#discussion_r163648777
  
    --- Diff: 
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
 ---
    @@ -102,6 +102,8 @@ private[hive] class SparkExecuteStatementOperation(
             to += from.getAs[Timestamp](ordinal)
           case BinaryType =>
             to += from.getAs[Array[Byte]](ordinal)
    +      case udt: UserDefinedType[_] =>
    +        to += from.get(ordinal).toString
    --- End diff --
    
    It is possible `from.get(ordinal)` returns `null`, then a null pointer 
exception. I think a better way to add this case is by the method 
`HiveUtils.toHiveString` method.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to