Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20399#discussion_r163980133
--- Diff:
core/src/test/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManagerSuite.scala
---
@@ -110,7 +111,64 @@ class HadoopDelegationTokenManagerSuite extends
SparkFunSuite with Matchers {
creds.getAllTokens.size should be (0)
}
+ test("SPARK-23209: obtain tokens when Hive classes are not available") {
+ // This test needs a custom class loader to hide Hive classes which
are in the classpath.
+ // Because the manager code loads the Hive provider directly instead
of using reflection, we
--- End diff --
just for my understandning, is there any reason the manager should load the
code directly, rather than using reflection to guard against this? I guess
either way is fine, I just had seen us use reflection more to guard against
this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
