Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20399#discussion_r164223721
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala
 ---
    @@ -75,6 +75,17 @@ private[spark] class HadoopDelegationTokenManager(
           .toMap
       }
     
    +  private def safeCreateProvider(
    +      createFn: => HadoopDelegationTokenProvider): 
Option[HadoopDelegationTokenProvider] = {
    +    try {
    +      Some(createFn)
    +    } catch {
    +      case t: Throwable =>
    +        logDebug(s"Failed to load built in provider.", t)
    --- End diff --
    
    I think debug is right, actually -- we have no idea at this point if the 
user wants these credential providers, and it could be totally fine if they're 
missing eg. if they never want to talk to hive.
    
    (also don't really care that much and don't want to bike-shed on this ...)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to