Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20397#discussion_r164342995 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/SupportsScanColumnarBatch.java --- @@ -30,21 +30,21 @@ @InterfaceStability.Evolving public interface SupportsScanColumnarBatch extends DataSourceV2Reader { @Override - default List<ReadTask<Row>> createReadTasks() { + default List<DataReaderFactory<Row>> createDataReaderFactories() { --- End diff -- I see, make sense. Maybe update the comment to explain why we need a list of `DataReaderFactory`s?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org