Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20427#discussion_r164619561
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/ReadSupport.java ---
@@ -18,23 +18,23 @@
package org.apache.spark.sql.sources.v2;
import org.apache.spark.annotation.InterfaceStability;
-import org.apache.spark.sql.sources.v2.reader.DataSourceV2Reader;
+import org.apache.spark.sql.sources.v2.reader.DataSourceReader;
/**
* A mix-in interface for {@link DataSourceV2}. Data sources can implement
this interface to
* provide data reading ability and scan the data from the data source.
*/
@InterfaceStability.Evolving
-public interface ReadSupport {
+public interface ReadSupport extends DataSourceV2 {
/**
- * Creates a {@link DataSourceV2Reader} to scan the data from this data
source.
+ * Creates a {@link DataSourceReader} to scan the data from this data
source.
*
* If this method fails (by throwing an exception), the action would
fail and no Spark job was
* submitted.
*
* @param options the options for the returned data source reader, which
is an immutable
* case-insensitive string-to-string map.
*/
- DataSourceV2Reader createReader(DataSourceV2Options options);
+ DataSourceReader createReader(DataSourceV2Options options);
--- End diff --
good point, let me rename it too.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
