Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20361#discussion_r164634402 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.java --- @@ -49,8 +49,9 @@ * After creating, `initialize` and `initBatch` should be called sequentially. */ public class OrcColumnarBatchReader extends RecordReader<Void, ColumnarBatch> { - // TODO: make this configurable. - private static final int CAPACITY = 4 * 1024; + + // The default size of vectorized batch. --- End diff -- maybe we can remove the comment. It's just the capacity, not a default value.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org