Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20386#discussion_r164680877
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/MemorySinkV2Suite.scala
---
@@ -41,19 +41,22 @@ class MemorySinkV2Suite extends StreamTest with
BeforeAndAfter {
test("continuous writer") {
val sink = new MemorySinkV2
val writer = new MemoryStreamWriter(sink, OutputMode.Append())
- writer.commit(0,
- Array(
- MemoryWriterCommitMessage(0, Seq(Row(1), Row(2))),
- MemoryWriterCommitMessage(1, Seq(Row(3), Row(4))),
- MemoryWriterCommitMessage(2, Seq(Row(6), Row(7)))
- ))
+ val messages = Seq(
+ MemoryWriterCommitMessage(0, Seq(Row(1), Row(2))),
+ MemoryWriterCommitMessage(1, Seq(Row(3), Row(4))),
+ MemoryWriterCommitMessage(2, Seq(Row(6), Row(7)))
+ )
+ messages.foreach(writer.add(_))
--- End diff --
nit:
```
writer.add(MemoryWriterCommitMessage(0, Seq(Row(1), Row(2))))
writer.add(MemoryWriterCommitMessage(1, Seq(Row(3), Row(4))))
..
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
