Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20408#discussion_r164874798
  
    --- Diff: core/src/main/scala/org/apache/spark/status/LiveEntity.scala ---
    @@ -423,7 +425,8 @@ private class LiveStage extends LiveEntity {
           newAccumulatorInfos(info.accumulables.values),
           None,
           None,
    -      killedSummary)
    +      killedSummary,
    +      blackListedExecutors)
    --- End diff --
    
    oh hmm, I had actually just meant storing this as a variable in 
`LiveStage`, but not including it in `v1.StageData`.  Do you think its useful 
to have this in api itself?  opinions @tgravescs ?  its already present in a 
per-executor flag, but there is not summary for the entire stage, to give a 
list of the blacklisted executors.  Just having it in the `LiveStage` is enough 
to get the performance improvement I had mentioned earlier.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to