Github user rekhajoshm commented on a diff in the pull request:
https://github.com/apache/spark/pull/20378#discussion_r164926603
--- Diff: dev/lint-python ---
@@ -83,6 +84,53 @@ else
rm "$PEP8_REPORT_PATH"
fi
+#### Python Document Style Checks ####
+
+# Get PYDOCSTYLE at runtime so that we don't rely on it being installed on
the build server.
+# Using pep257.py which is the single file version of pydocstyle.
+PYDOCSTYLE_VERSION="0.2.1"
+PYDOCSTYLE_SCRIPT_PATH="$SPARK_ROOT_DIR/dev/pydocstyle-$PYDOCSTYLE_VERSION.py"
+PYDOCSTYLE_SCRIPT_REMOTE_PATH="https://raw.githubusercontent.com/PyCQA/pydocstyle/$PYDOCSTYLE_VERSION/pep257.py";
--- End diff --
Thanks @BryanCutler for your input. pep8 is replaced by pycodestyle from
official PyPi channel in PR #20338 .This is for doc style alone, which is not
maintained within pycodestyle as per maintainers of the project -
https://github.com/PyCQA/pycodestyle/issues/723
On the other hand, there is value and we could try to somehow setup latest
pydocstyle from git(it would need setup on fly) rather than using single file
version.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
