GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/20452
revert [SPARK-22785][SQL] remove ColumnVector.anyNullsSet
## What changes were proposed in this pull request?
In https://github.com/apache/spark/pull/19980 , we thought `anyNullsSet`
can be simply implemented by `numNulls() > 0`. This is logically true, but may
have performance problems.
`OrcColumnVector` is an example. It doesn't have the `numNulls` property,
only has a `noNulls` property. We will lose a lot of performance if we use
`numNulls() > 0` to check null.
This PR simply revert #19980, with a renaming to call it `hasNull`. Better
name suggestions are welcome, e.g. `nullable`?
## How was this patch tested?
existing test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark null
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20452.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20452
----
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
