Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/20386
@rdblue @cloud-fan @jose-torres thanks for the comments!
I was trying to make the API compatible with `onTaskCommit(taskCommit:
TaskCommitMessage)` in `FileCommitProtocol` possible.
The reason that I removed arguments in `commit` and `abort` is that these
arguments seems redundant with the new API `add(WriterCommitMessage message)`.
After consideration, I decide to take the suggestion from @jose-torres :
create a new API for commit message call back, and remain the api `commit` and
`abort` as what they were.
Here is the new PR: https://github.com/apache/spark/pull/20454
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
