GitHub user viirya opened a pull request:

    https://github.com/apache/spark/pull/20455

    [SPARK-23284][SQL] Document several get API of ColumnVector's behavior when 
accessing null slot

    ## What changes were proposed in this pull request?
    
    For some ColumnVector get APIs such as getDecimal, getBinary, getStruct, 
getArray, getInterval, getUTF8String, we should clearly document their 
behaviors when accessing null slot. They should return null in this case. Then 
we can remove null checks from the places using above APIs.
    
    ## How was this patch tested?
    
    Existing tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/viirya/spark-1 SPARK-23272-followup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20455.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20455
    
----
commit 5ef0ba874dd879705f79ab1a986245df9605cad0
Author: Liang-Chi Hsieh <viirya@...>
Date:   2018-01-31T14:03:01Z

    Document several get API of ColumnVector's behavior when accessing null 
slot.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to