[GitHub] spark pull request #20327: [SPARK-12963][CORE] NM host for driver end points

[jiangxb1987]

Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20327#discussion_r165193521
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -744,7 +744,9 @@ object SparkSubmit extends CommandLineUtils with 
Logging {
         }
     
         // Ignore invalid spark.driver.host in cluster modes.
    -    if (deployMode == CLUSTER) {
    +    if (isYarnCluster) {
    +      sparkConf.set("spark.driver.host", "${env:NM_HOST}")
    --- End diff --
    
    This actually requires `spark.sql.variable.substitute` set to `true`, 
though by default it is, if some user accidentally changes it, the code won't 
work.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org