Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20450#discussion_r165242401
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
 ---
    @@ -530,7 +530,7 @@ public int putByteArray(int rowId, byte[] value, int 
offset, int length) {
       @Override
       protected void reserveInternal(int newCapacity) {
         int oldCapacity = (nulls == 0L) ? 0 : capacity;
    -    if (isArray()) {
    +    if (isArray() || type instanceof MapType) {
    --- End diff --
    
    This might be an overkill, `isArray` needs to take care of many types, but 
`isMap` we only accept one type: MapType.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to