Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20455#discussion_r165300767
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
 ---
    @@ -1261,4 +1261,140 @@ class ColumnarBatchSuite extends SparkFunSuite {
         batch.close()
         allocator.close()
       }
    +
    +  testVector("getUTF8String should return null for null slot", 4, 
StringType) {
    --- End diff --
    
    Seems we don't have individual tests for binary type and decimal type?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to