Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20460#discussion_r165360148
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -267,7 +267,7 @@ private[deploy] class SparkSubmitArguments(args:
Seq[String], env: Map[String, S
&& Try(JavaUtils.byteStringAsBytes(executorMemory)).getOrElse(-1L)
<= 0) {
SparkSubmit.printErrorAndExit("Executor Memory cores must be a
positive number")
}
- if (executorCores != null && Try(executorCores.toInt).getOrElse(-1) <=
0) {
+ if (executorCores != null &&
Try(executorCores.toDouble).getOrElse(-1d) <= 0d) {
--- End diff --
Although I think "0.0" is more readable than "0d", don't bother changing it
here. Just an aside
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
