Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20476#discussion_r165375177
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PushDownOperatorsToDataSource.scala
 ---
    @@ -81,35 +81,34 @@ object PushDownOperatorsToDataSource extends 
Rule[LogicalPlan] with PredicateHel
     
         // TODO: add more push down rules.
     
    -    // TODO: nested fields pruning
    -    def pushDownRequiredColumns(plan: LogicalPlan, requiredByParent: 
Seq[Attribute]): Unit = {
    -      plan match {
    -        case Project(projectList, child) =>
    -          val required = 
projectList.filter(requiredByParent.contains).flatMap(_.references)
    --- End diff --
    
    This line is wrong and I fixed to 
https://github.com/apache/spark/pull/20476/files#diff-b7f3810e65a2bb1585de9609ea491469R93


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to