Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20474#discussion_r165377861
  
    --- Diff: 
core/src/main/scala/org/apache/spark/status/api/v1/OneApplicationResource.scala 
---
    @@ -51,6 +52,21 @@ private[v1] class AbstractApplicationResource extends 
BaseAppResource {
       @Path("executors")
       def executorList(): Seq[ExecutorSummary] = 
withUI(_.store.executorList(true))
     
    +  @GET
    +  @Path("executors/{executorId}/threads")
    +  def threadDump(@PathParam("executorId") executorId: String):
    +  Option[Array[ThreadStackTrace]] = withUI { ui =>
    --- End diff --
    
    if this doesn't fit on oneline, the style is to still put each param on its 
own line
    
    ```scala
    def threadDump(
        @PathParam("executorId") executorId: String): 
Option[Array[ThreadStackTrace]] = ...
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to