Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20479#discussion_r165557435
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala
 ---
    @@ -655,4 +655,35 @@ class OrcQuerySuite extends OrcQueryTest with 
SharedSQLContext {
           }
         }
       }
    +
    +  testQuietly("Enabling/disabling ignoreMissingFiles") {
    --- End diff --
    
    Basically, this is copied from Parquet. To avoid duplicate codes, create a 
common base test class for parquet and orc? Then, we can deduplicate the codes? 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to