Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20487#discussion_r165883842
--- Diff: pom.xml ---
@@ -185,6 +185,10 @@
<paranamer.version>2.8</paranamer.version>
<maven-antrun.version>1.8</maven-antrun.version>
<commons-crypto.version>1.0.0</commons-crypto.version>
+ <!--
+ If you are changing Arrow version specification, please check
./python/pyspark/sql/utils.py,
+ ./python/run-tests.py and ./python/setup.py too.
--- End diff --
Hmmmm .. I thought the proper place to upgrade the versions should be in
`setup.py` and `pom.xml` so if we happen to update PyArrow (`pom.xml` /
`setup.py`) or Pandas (`setup.py`), I thought we are going to take a look for
either place first.
To be honest, I actually don't quite like to write down specific paths in
those comments because if we happen to move, we should update all the comments
..
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
