Github user icexelloss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20531#discussion_r166648140
  
    --- Diff: python/pyspark/sql/tests.py ---
    @@ -4289,14 +4297,15 @@ def data(self):
                 .withColumn("v", explode(col('vs'))).drop('vs')
     
         def test_simple(self):
    -        from pyspark.sql.functions import pandas_udf, PandasUDFType
    -        df = self.data
    +        from pyspark.sql.functions import pandas_udf, PandasUDFType, 
array, col
    +        df = self.data.withColumn("arr", array(col("id")))
    --- End diff --
    
    minor: It seems a bit arbitrary to mix array type in this test. Array 
probably belongs to `test_array`, `test_complex_type` sth like `test_all_types`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to