Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20559#discussion_r167391496
  
    --- Diff: python/pyspark/sql/tests.py ---
    @@ -2867,6 +2867,35 @@ def 
test_create_dataframe_required_pandas_not_found(self):
                                         "d": [pd.Timestamp.now().date()]})
                     self.spark.createDataFrame(pdf)
     
    +    # Regression test for SPARK-23360
    +    @unittest.skipIf(not _have_pandas, _pandas_requirement_message)
    +    def test_create_dateframe_from_pandas_with_dst(self):
    +        import pandas as pd
    +        from datetime import datetime
    +
    +        pdf = pd.DataFrame({'time': [datetime(2015, 10, 31, 22, 30)]})
    +
    +        df = self.spark.createDataFrame(pdf)
    +        self.assertPandasEqual(pdf, df.toPandas())
    +
    +        orig_env_tz = os.environ.get('TZ', None)
    +        orig_session_tz = self.spark.conf.get('spark.sql.session.timeZone')
    +        try:
    +            tz = 'America/Los_Angeles'
    +            os.environ['TZ'] = tz
    +            time.tzset()
    +            self.spark.conf.set('spark.sql.session.timeZone', tz)
    +
    +            df = self.spark.createDataFrame(pdf)
    +            df.show()
    --- End diff --
    
    gentle reminder for it. Seems it's now there for debugging purpose I guess? 
:).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to