Github user omalley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20511#discussion_r167950837
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
 ---
    @@ -160,6 +160,16 @@ abstract class OrcSuite extends OrcTest with 
BeforeAndAfterAll {
           }
         }
       }
    +
    +  // This is a test case for ORC-285
    --- End diff --
    
    After a bit of digging, the problem that ORC-285 fixes was introduced in 
HIVE-9711. HIVE-9711 is included in Hive 1.2.0, but doesn't create a problem 
unless the vectorized ORC reader is used. That didn't become the default 
behavior until HIVE-11417, which was released in Hive 2.1.0. So Spark's other 
readers are fine as long as they don't use the vectorized reader.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to