Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2771#discussion_r19289432
--- Diff: sql/hive/src/test/scala/org/apache/spark/sql/QueryTest.scala ---
@@ -74,4 +76,30 @@ class QueryTest extends FunSuite {
""".stripMargin)
}
}
+
+ // The following copy is copied from
org.apache.spark.sql.catalyst.plans.PlanTest
--- End diff --
How about making `QueryTest` inherit from `PlanTest` instead? Just like
what we did in another `PlanTest` in `sql/core`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
