Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2886#discussion_r19294252
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
@@ -325,22 +325,23 @@ class BlockManagerMasterActor(val isLocal: Boolean,
conf: SparkConf, listenerBus
private def register(id: BlockManagerId, maxMemSize: Long, slaveActor:
ActorRef) {
val time = System.currentTimeMillis()
+
if (!blockManagerInfo.contains(id)) {
blockManagerIdByExecutor.get(id.executorId) match {
case Some(manager) =>
- // A block manager of the same executor already exists.
- // This should never happen. Let's just quit.
- logError("Got two different block manager registrations on " +
id.executorId)
- System.exit(1)
+ // A block manager of the same executor already exists so remove
it (assumed dead).
--- End diff --
actually what I meant was to add a comma between "exists" and "so"... It's
ok I can fix this myself when I merge it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
