Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/20627#discussion_r169156086
--- Diff: python/pyspark/ml/evaluation.py ---
@@ -394,15 +397,30 @@ def getMetricName(self):
@keyword_only
@since("2.3.0")
def setParams(self, predictionCol="prediction", featuresCol="features",
- metricName="silhouette"):
+ metricName="silhouette",
distanceMeasure="squaredEuclidean"):
--- End diff --
Yeah these will not cause any incompatibility issues, the interpreter would
automatically just pass the additional keyword arg. These methods are actually
all wrapped with `keyword_only` which make it look externally like
`setParams(**kwargs)`, anyway.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
