Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r169182053
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -512,16 +522,27 @@ case class Rint(child: Expression) extends
UnaryMathExpression(math.rint, "ROUND
case class Signum(child: Expression) extends
UnaryMathExpression(math.signum, "SIGNUM")
@ExpressionDescription(
- usage = "_FUNC_(expr) - Returns the sine of `expr`.",
+ usage = "_FUNC_(expr) - Returns the sine of `expr`, as if computed by
`java.lang.Math._FUNC_`.",
+ arguments =
+ """
+ Arguments:
+ * expr - angle in radians
+ """,
examples = """
Examples:
> SELECT _FUNC_(0);
0.0
""")
case class Sin(child: Expression) extends UnaryMathExpression(math.sin,
"SIN")
+// scalastyle:off line.size.limit
--- End diff --
I think we should turn this on again
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
