Github user squito commented on the issue:

    https://github.com/apache/spark/pull/20640
  
    @IgorBerman I actually think that 
https://github.com/apache/spark/pull/17619 is the right approach.  As @timout 
pointed out on that one, this functionality doesn't need to be covered in mesos 
specific code at all, as its covered by the BlacklistTracker.  I don't like 
introducing new configs when we don't really need them.  Other than this being 
less invasive, is there another advantage here?
    
    The modifications I suggested to that PR are relatively small -- I think 
its fine if you want to open a PR that is the original updated with my 
suggestions (credit still to @timout), as I'm not sure if they're still working 
on it.  (my fault too as there was such a long delay for a proper review.)
    
    While I had some open questions, I think its a clear improvement in any 
case.  I just need to get a little help on mesos testing, we can ask on the dev 
list.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to