Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/17619#discussion_r169458952
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -484,7 +481,6 @@ private[spark] class MesosCoarseGrainedSchedulerBackend(
cpus + totalCoresAcquired <= maxCores &&
mem <= offerMem &&
numExecutors() < executorLimit &&
- slaves.get(slaveId).map(_.taskFailures).getOrElse(0) <
MAX_SLAVE_FAILURES &&
--- End diff --
thanks @skonto , also I realized there was more explicit calls to
declineOffer than I thought initially after a closer read of the code. btw
@IgorBerman has opened an updated version of this PR here
https://github.com/apache/spark/pull/20640 -- would appreciate a review over
there
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
