Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r169834018
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala ---
@@ -359,29 +339,6 @@ class DecisionTreeSuite extends SparkFunSuite with
MLlibTestSparkContext {
assert(rootNode.stats.isEmpty)
}
- test("do not choose split that does not satisfy min instance per node
requirements") {
- // if a split does not satisfy min instances per node requirements,
- // this split is invalid, even though the information gain of split is
large.
- val arr = Array(
- LabeledPoint(0.0, Vectors.dense(0.0, 1.0)),
--- End diff --
Here again. You can fix this by inverting the labels. Probably an easier
fix than moving and re-writing the test.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
