Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20362#discussion_r170047180
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
    @@ -693,7 +766,7 @@ class ALSSuite
         val data = ratings.toDF
         val model = new ALS().fit(data)
         Seq("nan", "NaN", "Nan", "drop", "DROP", "Drop").foreach { s =>
    -      model.setColdStartStrategy(s).transform(data)
    +      testTransformer[Rating[Int]](data, model.setColdStartStrategy(s), 
"prediction") { _ => }
    --- End diff --
    
    What's the no-op function at the end for -- just because it requires an 
argument?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to