Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20673#discussion_r170477844
  
    --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
    @@ -100,7 +102,16 @@ private[spark] object JsonProtocol {
             executorMetricsUpdateToJson(metricsUpdate)
           case blockUpdate: SparkListenerBlockUpdated =>
             blockUpdateToJson(blockUpdate)
    -      case _ => parse(mapper.writeValueAsString(event))
    +      case _ =>
    +        val outputStream = new PipedOutputStream()
    --- End diff --
    
    Hi @brkyvz, how about adding a note that `PipedOutputStream` is 
intentionally used to get rid of additional consumption of memory if I get this 
correctly?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to