Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r170520696
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -50,12 +52,11 @@
// These are only updated by readExternal() or read()
@Nonnull
- private Object base;
- private long offset;
+ private MemoryBlock base;
private int numBytes;
--- End diff --
Yeah, since I incrementally use `MemoryBlock`, some fields still remains as
duplicated.
I think that `UTF8String.length` can be used projected into
`MemoryBlock.length` since `UTF8String` seems immutable.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
