Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20670#discussion_r170529062
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala
 ---
    @@ -29,12 +29,26 @@ trait QueryPlanConstraints { self: LogicalPlan =>
        */
       lazy val constraints: ExpressionSet = {
         if (conf.constraintPropagationEnabled) {
    +      var relevantOutPutSet: AttributeSet = outputSet
    +      constraints.foreach {
    +        case eq @ EqualTo(l: Attribute, r: Attribute) =>
    +          if (l.references.subsetOf(relevantOutPutSet)
    +            && !r.references.subsetOf(relevantOutPutSet)) {
    +            relevantOutPutSet = relevantOutPutSet.++(r.references)
    --- End diff --
    
    Use ` ++ ` syntax, rather than write it as a method invocation.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to