[GitHub] spark pull request #20681: [SPARK-23518][SQL] Avoid metastore access when th...

[felixcheung]

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20681#discussion_r170862425
  
    --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
    @@ -885,24 +894,24 @@ test_that("collect() and take() on a DataFrame return 
the same number of rows an
     })
     
     test_that("collect() support Unicode characters", {
    -  lines <- c("{\"name\":\"안녕하세요\"}",
    -             "{\"name\":\"您好\", \"age\":30}",
    -             "{\"name\":\"こんにちは\", \"age\":19}",
    -             "{\"name\":\"Xin chào\"}")
    +  lines <- c("{\"name\":\"?????\"}",
    +             "{\"name\":\"??\", \"age\":30}",
    +             "{\"name\":\"?????\", \"age\":19}",
    +             "{\"name\":\"Xin ch?o\"}")
    --- End diff --
    
    no, we should not change these


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org