Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20667#discussion_r170884966
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerId.scala
---
@@ -132,10 +133,15 @@ private[spark] object BlockManagerId {
getCachedBlockManagerId(obj)
}
- val blockManagerIdCache = new ConcurrentHashMap[BlockManagerId,
BlockManagerId]()
+ val blockManagerIdCache = CacheBuilder.newBuilder()
+ .maximumSize(500)
--- End diff --
Please feel free to update any comment, and I would set the default value
to 10000 since I think cost of 500KB memory is feasible.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
