Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20663#discussion_r170910979
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllStagesPage.scala
---
@@ -67,152 +41,120 @@ private[ui] class AllStagesPage(parent: StagesTab)
extends WebUIPage("") {
}.toMap
val poolTable = new PoolTable(pools, parent)
- val shouldShowActiveStages = activeStages.nonEmpty
- val shouldShowPendingStages = pendingStages.nonEmpty
- val shouldShowCompletedStages = completedStages.nonEmpty
- val shouldShowSkippedStages = skippedStages.nonEmpty
- val shouldShowFailedStages = failedStages.nonEmpty
+ val allStatuses = Seq(StageStatus.ACTIVE, StageStatus.PENDING,
StageStatus.COMPLETE,
+ StageStatus.SKIPPED, StageStatus.FAILED)
+ val allStages = parent.store.stageList(null)
val appSummary = parent.store.appSummary()
- val completedStageNumStr = if (appSummary.numCompletedStages ==
completedStages.size) {
- s"${appSummary.numCompletedStages}"
- } else {
- s"${appSummary.numCompletedStages}, only showing
${completedStages.size}"
- }
+
+ val (summaries, tables) = allStatuses.map(
--- End diff --
since there is some (few) logic which is common to the two (ie. when they
are empty), I chose this approach in order to avoid redundancy and enforce
coherence. But I am fine also having two separate functions. What do you think
@vanzin ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
