Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20696#discussion_r171285332
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala 
---
    @@ -1597,6 +1597,7 @@ abstract class DDLSuite extends QueryTest with 
SQLTestUtils {
         // Ensure that change column will preserve other metadata fields.
         sql("ALTER TABLE dbx.tab1 CHANGE COLUMN col1 col1 INT COMMENT 'this is 
col1'")
         assert(getMetadata("col1").getString("key") == "value")
    +    assert(getMetadata("col1").getString("comment") == "this is col1")
    --- End diff --
    
    I didn't verify the comment is correctly set to the column metadata, and 
that caused the issue. :(


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to