Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20700#discussion_r171525213
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -773,7 +773,7 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
| ${if (i != 0) s"""$buffer.append(" ");""" else ""}
|
| // Append $i field into the string buffer
- | ${ctx.javaType(ft)} $field = ${ctx.getValue(row, ft, s"$i")};
+ | ${ctx.javaType(ft)} $field = ${CodeGenerator.getValue(row, ft,
s"$i")};
--- End diff --
Some methods that are very frequently used (e.g. `ctx.javaType()`) are not
refactored yet. This is because this refactoring updates more files.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
