Github user rdblue commented on the issue:

    https://github.com/apache/spark/pull/20692
  
    > I think you can add the patch to your fork.
    
    My primary concern isn't the feature, although I do think it is useful. My 
concern is how we work with contributors. My worry here is that the objections 
are not on the merits of this PR.
    
    Telling a contributor to either take on something much larger or come back 
in a few months is discouraging and stifles contributions. This patch is here 
now, and the focus should be on either why the idea is a not good one (i.e., 
*why* types should not go in plans) or what should be improved to fix the 
implementation. That could also be to propose a better alternative, but without 
an alternate proposal, asking for something different without constructive 
criticism of the PR leaves me, at least, simply confused.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to