Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r171736235
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -50,12 +52,10 @@
// These are only updated by readExternal() or read()
@Nonnull
- private Object base;
- private long offset;
- private int numBytes;
+ private MemoryBlock base;
- public Object getBaseObject() { return base; }
- public long getBaseOffset() { return offset; }
+ public MemoryBlock getBaseObject() { return base; }
--- End diff --
We can drop this function by preparing `public MemoryBlock getMemoryBlock()
{ return base; }`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
