Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20464#discussion_r172033021
--- Diff: R/pkg/R/column.R ---
@@ -169,7 +169,7 @@ setMethod("alias",
#' @note substr since 1.4.0
setMethod("substr", signature(x = "Column"),
function(x, start, stop) {
- jc <- callJMethod(x@jc, "substr", as.integer(start - 1),
as.integer(stop - start + 1))
+ jc <- callJMethod(x@jc, "substr", as.integer(start),
as.integer(stop - start + 1))
--- End diff --
I think we should do two things:
1. add to the func doc that the `start` param should be 0-base and to add
to the example with the result
`collect(select(df, substr(df$a, 0, 5))) # this should give you...`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
