Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20727#discussion_r172328966
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileLinesReader.scala
---
@@ -30,9 +30,19 @@ import
org.apache.hadoop.mapreduce.task.TaskAttemptContextImpl
/**
* An adaptor from a [[PartitionedFile]] to an [[Iterator]] of [[Text]],
which are all of the lines
* in that file.
+ *
+ * @param file A part (i.e. "block") of a single file that should be read
line by line.
+ * @param lineSeparator A line separator that should be used for each
line. If the value is `\n`,
+ * it covers `\r`, `\r\n` and `\n`.
+ * @param conf Hadoop configuration
*/
class HadoopFileLinesReader(
- file: PartitionedFile, conf: Configuration) extends Iterator[Text]
with Closeable {
+ file: PartitionedFile,
+ lineSeparator: String,
--- End diff --
A constructor of LineRecordReader has the same param but its type is array
of bytes. I would propose to expose the same type here - Array[Byte]. Also you
handle special value - '\n'. If you define the param as lineSeparator:
Option[Array[Byte]], None would indicate default behavior - '\n', '\r' or
'\r\n'
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
