Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20633#discussion_r172420910
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---
@@ -351,17 +359,21 @@ private[ml] object DefaultParamsReader {
timestamp: Long,
sparkVersion: String,
params: JValue,
+ defaultParams: JValue,
metadata: JValue,
metadataJson: String) {
/**
* Get the JSON value of the [[org.apache.spark.ml.param.Param]] of
the given name.
* This can be useful for getting a Param value before an instance of
`Params`
* is available.
+ *
+ * @param isDefaultParam Whether the given param name is a default
param. Default is false.
*/
- def getParamValue(paramName: String): JValue = {
+ def getParamValue(paramName: String, isDefaultParam: Boolean = false):
JValue = {
--- End diff --
Sounds good. I will change this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
