Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/2884#discussion_r19362161
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScan.scala
---
@@ -81,7 +81,8 @@ case class HiveTableScan(
// Specifies needed column IDs for those non-partitioning columns.
val neededColumnIDs =
attributes.map(a =>
- relation.attributes.indexWhere(_.name == a.name):
Integer).filter(index => index >= 0)
+ relation.attributes.indexWhere(
+ _.name.toLowerCase == a.name.toLowerCase): Integer).filter(index
=> index >= 0)
--- End diff --
Yes, column names are case insensitive in hive, we should use lowercase for
names in hive module(only change here is not enough, also need convert to
lowercase there
https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala#L273).
I think using an AttributeMap can not fix this problem, how about add a
lowerName for ```Attribute``` and in hive we use this method instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
