Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20753#discussion_r172722081 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -133,8 +134,21 @@ case class StaticInvoke( override def nullable: Boolean = needNullCheck || returnNullable override def children: Seq[Expression] = arguments - override def eval(input: InternalRow): Any = - throw new UnsupportedOperationException("Only code-generated evaluation is supported.") + override def eval(input: InternalRow): Any = { + if (staticObject == null) { + throw new RuntimeException("The static class cannot be null.") + } + + val parmTypes = arguments.map(e => + CallMethodViaReflection.typeMapping.getOrElse(e.dataType, + Seq(e.dataType.asInstanceOf[ObjectType].cls))(0)) --- End diff -- You are right. I have to support other types before merging this change. This is a prototype for discussing whether we use reflection or not.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org