GitHub user mgaido91 opened a pull request:

    https://github.com/apache/spark/pull/20772

    [SPARK-23628][SQL] calculateParamLength should not return 1 + num of 
epressions

    ## What changes were proposed in this pull request?
    
    There was a bug in `calculateParamLength` which caused it to return always 
1 + the number of expressions. This could lead to Exceptions especially with 
expressions of type long.
    
    ## How was this patch tested?
    
    added UT + fixed previous UT


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgaido91/spark SPARK-23628

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20772.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20772
    
----
commit bd89841f034bd4fc43749afa9174189276f3cdf9
Author: Marco Gaido <marcogaido91@...>
Date:   2018-03-08T14:08:31Z

    [SPARK-23628][SQL] Fix calculateParamLength

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to