Github user bersprockets commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20705#discussion_r173275865
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala 
---
    @@ -2476,7 +2477,7 @@ class SQLQuerySuite extends QueryTest with 
SharedSQLContext {
         withTempDir { dir =>
           val parquetDir = new File(dir, "parquet").getCanonicalPath
           spark.range(10).withColumn("_col", 
$"id").write.partitionBy("_col").save(parquetDir)
    --- End diff --
    
    Since the data format may not be parquet, maybe the directory name should 
be more generic, like dataDir.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to