Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20759#discussion_r173379554
  
    --- Diff: docs/ml-collaborative-filtering.md ---
    @@ -19,6 +19,7 @@ by a small set of latent factors that can be used to 
predict missing entries.
     algorithm to learn these latent factors. The implementation in `spark.ml` 
has the
     following parameters:
     
    +* *checkpointInterval* helps with recovery when nodes fail and 
StackOverflow exceptions caused by long lineage. **Will be silently ignored if 
*SparkContext.CheckpointDir* is not set.** (defaults to 10).
    --- End diff --
    
    the wording is a bit severe... do we have to say node failure or 
stackoverflow (latter should be rare anyway?)
    
    also is this list of param sorted in any way? perhaps add 
checkpointInterval to the end?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to