Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20756#discussion_r173405112
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1261,8 +1261,39 @@ case class InitializeJavaBean(beanInstance:
Expression, setters: Map[String, Exp
override def children: Seq[Expression] = beanInstance +:
setters.values.toSeq
override def dataType: DataType = beanInstance.dataType
- override def eval(input: InternalRow): Any =
- throw new UnsupportedOperationException("Only code-generated
evaluation is supported.")
+ private lazy val resolvedSetters = {
+ val ObjectType(beanClass) = beanInstance.dataType
+ setters.map {
+ case (name, expr) =>
+ // Looking for known type mapping first, then using Class attached
in `ObjectType`.
+ // Finally also looking for general `Object`-type parameter for
generic methods.
+ val paramTypes =
CallMethodViaReflection.typeMapping.getOrElse(expr.dataType,
--- End diff --
I see. Is it better to have separate map variables? cc @hvanhovell
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
